Avoid unecessary copy when reading arrow files #11840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiangpengHao
force-pushed
the
string-view-stable
branch
from
ae23cd5
to
47be719
Compare
XiangpengHao
changed the title
alamb
reviewed
Aug 6, 2024
| decoder.read_dictionary(dict_block, &dict_result.into())?; | ||
| decoder.read_dictionary( | ||
| dict_block, | ||
| &Buffer::from_bytes(dict_result.into()), |
There was a problem hiding this comment.
👍 this was doing an implicit copy before
|
Merged up to resolve a conflict |
alamb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11752.
Rationale for this change
I'm pushing
string-viewto stable, and fixing some incoming breaking changes. Related arrow changes: apache/arrow-rs#6043Specifically, I think we avoided some accidental copies by incooperating the changes from arrow
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?